Re: Field peVariable of http_url_encoder is too short

[Thomas Raddatz <thomas.raddatz@xxxxxxxxxxx>]

Hi Scott,

It was great if you could do that. Most likely it is almost the same
work when you adopt my changes or when you add the necessary changes.

I am in trouble with my Kodi, TVheadend and NAS configuration and hence
there is little time left at home for other things.

But of course I do it, in case you have similar problems.

Regards,

Thomas.

Am 12.01.2016 um 03:00 schrieb Scott Klement:
> Thomas,
> 
> It looks like http_url_encoder_addvar() is passing the peVariable
> parameter by value.  I don't remember why I did that...  but that was a
> bad decision on my part.  Unfortunately, since the caller has to put the
> entire value on the stack, you can't increase the size of peVariable
> without breaking backward compatibility.  (If it were passed by
> reference this would not be a problem.)
> 
> What you'll need to do is create new procedures for the long names. You
> can keep the old procedures and have them call the new procedures under
> the covers to maintain compatibility.
> 
> So perhaps have a procedure named:
> 
>        http_url_encoder_setvar()
> 
> Use options(*string) for both the variable name and it's value, this way
> the length has no limit.  Then keep http_url_encoder_addvar and
> http_url_encoder_addvar_s, but change their internals to call
> http_url_encoder_setvar() internally.
> 
> If you like, I can make this change.
> 
> -SK
> 
> 
> On 1/11/2016 4:01 PM, Thomas Raddatz wrote:
>> Hi Scott,
>>
>> A friend of mine tries to call the Amazon CreateShipment web service.
>>
>> http://docs.developer.amazonservices.com/en_US/merch_fulfill/MerchFulfill_CreateShipment.html
>>
>>
>> Unfortunately field peVariable is too short to take variable names such
>> as "ShipmentRequestDetails.ShippingServiceOptions.DeliveryExperience".
>>
>>  From your point of view, can we safely increase the length of peVariable
>> and return the changes to the HTTPAPI project?
>>
>> For now the idea is to increase the size up to 128 byte.
>>
>> Affected procedures:
>>
>>    http_url_encoder_addvar_s()
>>    http_url_encoder_addvar()
>>
>> Regards,
>>
>> Thomas.
>> -----------------------------------------------------------------------
>> This is the FTPAPI mailing list.  To unsubscribe, please go to:
>> http://www.scottklement.com/mailman/listinfo/ftpapi
>> -----------------------------------------------------------------------
>>
> 
> -----------------------------------------------------------------------
> This is the FTPAPI mailing list.  To unsubscribe, please go to:
> http://www.scottklement.com/mailman/listinfo/ftpapi
> -----------------------------------------------------------------------
> 
-----------------------------------------------------------------------
This is the FTPAPI mailing list.  To unsubscribe, please go to:
http://www.scottklement.com/mailman/listinfo/ftpapi
-----------------------------------------------------------------------